From 693702307e6c1b9f9ea4a1f9fb461c7a69772631 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Brunner?= <stephane.brunner@camptocamp.com>
Date: Thu, 15 Aug 2024 17:41:04 +0200
Subject: [PATCH] Add missing entry in the schema for External Secret Docker
 registries

---
 templates/external-secret-docker-registry.yaml | 2 --
 values.md                                      | 2 ++
 values.schema.json                             | 8 ++++++++
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/templates/external-secret-docker-registry.yaml b/templates/external-secret-docker-registry.yaml
index f5ec423..f3a968d 100644
--- a/templates/external-secret-docker-registry.yaml
+++ b/templates/external-secret-docker-registry.yaml
@@ -15,9 +15,7 @@ spec:
   secretStoreRef: {{- toYaml . | nindent 4 }}
   {{- end }}
   target:
-    {{- if not ( hasKey ( default ( dict ) .target ) "name" ) }}
     name: {{ include "common.fullname" ( dict "root" $ "service" . "serviceName" "external-secret" ) }}
-    {{- end }}
     template:
       type: kubernetes.io/dockerconfigjson
       data:
diff --git a/values.md b/values.md
index 7db8f7b..b35b681 100644
--- a/values.md
+++ b/values.md
@@ -50,6 +50,8 @@
   - **`annotations`**: Refer to _[#/definitions/annotations](#definitions/annotations)_.
   - **`enabled`** _(boolean)_: Enable the Docker registry.
   - **`external`** _(boolean)_: Use an external secret to the Docker registries username, password and email.
+  - **`refreshInterval`** _(string)_: The refresh interval like 1h, 1m, 1s.
+  - **`secretStoreRef`** _(object)_: defines which SecretStore to fetch the ExternalSecret data.
   - **`content`** _(object)_: Docker registries authentication. Can contain additional properties.
     - **Additional properties** _(object)_: Cannot contain additional properties.
       - **`username`** _(string)_: Username.
diff --git a/values.schema.json b/values.schema.json
index 2670d9e..26f8fdb 100644
--- a/values.schema.json
+++ b/values.schema.json
@@ -450,6 +450,14 @@
           "type": "boolean",
           "description": "Use an external secret to the Docker registries username, password and email"
         },
+        "refreshInterval": {
+          "type": "string",
+          "description": "The refresh interval like 1h, 1m, 1s"
+        },
+        "secretStoreRef": {
+          "type": "object",
+          "description": "defines which SecretStore to fetch the ExternalSecret data."
+        },
         "content": {
           "type": "object",
           "description": "Docker registries authentication",