Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch from RT #169739 (sanity check in ForceInteract) #7

Open
jw35 opened this issue May 22, 2017 · 2 comments
Open

Apply patch from RT #169739 (sanity check in ForceInteract) #7

jw35 opened this issue May 22, 2017 · 2 comments
Labels

Comments

@jw35
Copy link

jw35 commented May 22, 2017

RAVEN092 in master TODO list

@jw35
Copy link
Author

jw35 commented May 22, 2017

Subject: Patch for mod_ucam_webauth
Date: Mon, 2 Jan 2012 18:29:06 +0000 (GMT)
To: [email protected]
From: "P. Benie" [email protected]
Download (untitled) [text/plain 518b]
Hi,

Please find a patch, enclosed, which fixes a problem with the sanity check
in ForceInteract (it could never have worked as written) and does some
sanity checking on key ID before feeding it into RSA_sig_verify;
the patch guarantees that only only files in can be reached.

The lack of checking on key ID can't be exploited on any normal
configuration - there would have to be a directory named with the right
prefix for there to be a problem, but I think it's better to program
defensively.

Peter

ucam_webauth_patch.diff.txt

@jw35
Copy link
Author

jw35 commented May 22, 2017

Note that different code to apply sanity checking to keyID has already been implemented.

@jw35 jw35 added the bug label May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant