Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #7

Open
camUrban opened this issue Mar 17, 2021 · 6 comments
Open

Testing #7

camUrban opened this issue Mar 17, 2021 · 6 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@camUrban
Copy link
Owner

We should make sure that all the integration tests compare output against expected results. This means getting rid of all the "test_method_does_not_throw" tests.

We could also implement PyTests or some other methodology with a simpler syntax.
@camUrban camUrban added documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers labels Mar 17, 2021
@ishansmishra
Copy link

Hey, I wanna help out with this issue :)

@camUrban
Copy link
Owner Author

@legitishan Let me know if you need any advice on this!

@ishansmishra
Copy link

Right, I can't run test_output.py, it throws a "ModuleNotFoundError: No module named 'tests'" error for some reason, The folder does contain a init.py file, any clue what might be causing this error?

@camUrban
Copy link
Owner Author

@legitishan Okay thanks for letting me know! I just made a new release (v1.1.2) that overhauled a lot of the package structure. Would you mind trying again with the latest version and let me know if that fixes your error?

@biswain2309
Copy link

Hey! Can I contribute to this issue?

@camUrban
Copy link
Owner Author

camUrban commented Oct 3, 2021

@biswain2309 Absolutely! Let me know if you have any issues getting started.

Repository owner deleted a comment from YISHISHEN Mar 22, 2022
@camUrban camUrban mentioned this issue Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@camUrban @ishansmishra @biswain2309