Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'q_a_pairs.csv' and the reference to it, replace it with the answerable_questions API call #132

Open
richagadgil opened this issue Apr 12, 2020 · 4 comments
Assignees

Comments

@richagadgil
Copy link
Member

api/QA.py

Line 190 in b5bde14

df = read_csv(csv)

Remove q_a_pairs.csv and the reference to it, replace it with the answerable_questions API call.
See #131 to see how answerable_questions api is used to populate dataframe.

@mfekadu
Copy link
Member

mfekadu commented Apr 12, 2020

@richagadgil does #131 take care of this issue?

@richagadgil
Copy link
Member Author

No, this issue is requesting @cameron-toy to replace his use of the q_a_pairs.csv with an API call to answerable_questions when possible. He can use my code as a reference because it does the same thing :)

@richagadgil
Copy link
Member Author

Then hopefully we can remove q_a_pairs.csv from the api repo

@cameron-toy
Copy link
Collaborator

@richagadgil This has been resolved right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants