Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-normalized chatbot responses #107

Open
Jason-Ku opened this issue Mar 3, 2020 · 1 comment
Open

Non-normalized chatbot responses #107

Jason-Ku opened this issue Mar 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Jason-Ku
Copy link
Contributor

Jason-Ku commented Mar 3, 2020

Describe the bug
Non-normalized responses from chatbot - (not capitalizing the first letter of the sentence, uses whatever was typed in).

Bug severity
Minor, non-blocker, purely aesthetic.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://nimbus.calpolycsai.com/
  2. Submit "What is kurfessss's phone number?" as a question and hit send
  3. Wait for a response
  4. See non-normalized response (will respond with kurfessss's phone number is xxx)

Expected behavior
I expected the output response to be normalized / "correct"

Screenshots
If applicable, add screenshots to help explain your problem.
image

Additional context
Should be a pretty easy fix - famous last words from @cameron-toy (but in all actuality, it should be - just need to return the normalized Entity name in the output)

@Jason-Ku Jason-Ku added the bug Something isn't working label Mar 3, 2020
@cameron-toy
Copy link
Collaborator

Unfortunately, it won't be quite as easy as returning the normalized Entity name. The normalized Entity is just the Entity string without titles (Professor, Dr., etc). To actually get a normalized name, we'll have to modify the db_query and format_answer methods for each QA object.

We'd also have to find a way to describe how to identify each type of entity. For example, professor names could be normalized as "Professor {last_name}" or as "{first_name} {last_name}"

More and more I'm feeling like we should have some sort of single "identifying_name" column for each entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants