Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosetta Flash JSONP abuse in ExpressJS #49

Closed
jerone opened this issue Oct 19, 2014 · 1 comment · May be fixed by #66
Closed

Rosetta Flash JSONP abuse in ExpressJS #49

jerone opened this issue Oct 19, 2014 · 1 comment · May be fixed by #66

Comments

@jerone
Copy link

jerone commented Oct 19, 2014

This extension is not compatible with the jsonp result that is returned by ExpressJS in NodeJS.
Express returns the following syntax:

/**/ typeof callback === 'function' && callback( ... );

As the source code documents, the /**/ is a specific security mitigation for "Rosetta Flash JSONP abuse". The typeof is for error checking.

I looked at the source but couldn't find an easy solution for PR. I hope you can fix this to make this extension even more useful.
@dhurrell dhurrell mentioned this issue Dec 14, 2015
Open
@jerone
Copy link
Author

jerone commented Sep 17, 2017

In an attempt to clean up my created issues that have not been processed or updated over a year, I'm closing this issue. If this issue is still relevant, please reopen another issue.

@jerone jerone closed this as completed Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strip out Express typeof check from JSONP dhurrell/json-formatter
2 participants
@jerone and others