Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor / querystring data missing #54

Open
eden-jh opened this issue Mar 25, 2022 · 3 comments
Open

Anchor / querystring data missing #54

eden-jh opened this issue Mar 25, 2022 · 3 comments
Labels

Comments

@eden-jh
Copy link

eden-jh commented Mar 25, 2022

The anchor/querystring data is not loaded into the editor after saving, and it's not included in the data on the front end. I haven't looked in any detail but it seems like this is because that field is missing from the class definitions for MeganavItem and MeganavEntity.

Steps to reproduce:

  1. In a new or existing Meganav content item, click the Add button to add a link to the navigation
  2. When the link Settings panel opens, enter a link URL and title, or select a page from the content tree
  3. Enter "#test" (or any other string) in the Anchor / querystring fields of the Settings
  4. Click Save on the settings panel
  5. Click Save and publish on the Meganav content item
  6. Hit your browser's refresh button
  7. Click the settings for the item you just added. When the settings panel opens, notice the Anchor / querystring field is blank. (If you open the front end of a page loading that navigation item's content, you'll see that the MeganavItem in the data has no Anchor or Querystring property, or any other property containing the data)

The Settings panel of a Meganav link, showing the Link, Anchor / querystring, and Link title fields. The Anchor / querystring field is set to '#test', and the panel shows the URL and name of the selected content node.

@callumbwhyte
Copy link
Owner

Thanks @eden-jh - we found this on a client site this week also! I will try and get a fix out this weekend.

@eden-jh
Copy link
Author

eden-jh commented May 4, 2022

@callumbwhyte I can take this one if you haven't gotten to it yet (not sure if you have something in progress locally).

@eden-jh
Copy link
Author

eden-jh commented May 4, 2022

Also, implementation question: The Multi URL Picker saves the QueryString and URL separately in the DB, but combines them into a single Url property in its value converter.

Should this be handled the same way in Meganav (combining the Url and QueryString in MeganavItem.Url), or does it make more sense to keep them separate? (There's also a third, albeit messy option to use one property for just the URL, one for just the QueryString, and one for the combined URL/QueryString.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants