Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding objects to a large position is slow #4

Open
jsoa opened this issue Aug 16, 2013 · 0 comments
Open

Adding objects to a large position is slow #4

jsoa opened this issue Aug 16, 2013 · 0 comments

Comments

@jsoa
Copy link
Member

jsoa commented Aug 16, 2013

If a position contains alot of items, adding an item to it is slow. It becomes even slower with more items in the position. This is when we are using add_object, which does some checking and re-ordering on the fly. While having over 500 items in a position is rare, the case where a position is used as a ban or white of users for example, the list may get large. In this case the order does not really matter and the re-order can be neglected

Suggested changes:

  • Add a manager method that just appends to the list taking the next order #
  • Add a bulk add object method that accepts a list of objects and uses the the list order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant