Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monosynth cannot receive on MIDI Channel 1 only #318

Open
riban-bw opened this issue Oct 14, 2022 · 0 comments
Open

Monosynth cannot receive on MIDI Channel 1 only #318

riban-bw opened this issue Oct 14, 2022 · 0 comments

Comments

@riban-bw
Copy link

Setting Monosynth's "MIDI Channel" parameter to 0 enables omni-mode, i.e. it will respond to any MIDI channel. Setting it to a value 1..15 will restrict response to MIDI channel 2..16. Setting to 16 disables MIDI input.

This is because the MIDI channel is checked for zero (*params[par_midi] ) for omni-mode and then checked against the zero-based value of its MIDI Channel parameter (channel != *params[par_midi]). It should be checked against an offset value, e.g.

if (*params[par_midi] && channel + 1 != *params[par_midi]) return;

This should then give the behaviour that setting the MIDI Channel parameter to zero enables omni-mode and setting to a value 1..16 constrains response to the corresponding MIDI channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant