Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

much slower s/it when run from CLI #6

Open
r-shruthi11 opened this issue Jan 12, 2023 · 4 comments
Open

much slower s/it when run from CLI #6

r-shruthi11 opened this issue Jan 12, 2023 · 4 comments

Comments

@r-shruthi11
Copy link

Thanks for creating and sharing this codebase. I noticed a big difference in how both data loading and fitting it/s or s/it when I call load_data or fit_model from the command line as opposed to within a jupyter notebook. Could this be related to tdqm printing progress to stdout vs. in the notebook?
(Also please let me know if there is a different forum to raise issues or discuss bug fixes) - SR

@calebweinreb
Copy link
Owner

Can you clarify what, exactly, is slower? The actual execution of the code? Or the rate of progress updates by tqdm? If it's possible to provide a minimal example to reproduce the issue and an example of the output, that would be helpful too.

@r-shruthi11
Copy link
Author

Hmm, good question. tqdm reports a value iterations/s or s/iteration. For example, the when you call fit_model there is a progress bar that reports this. This is what appears to be slower when I run this or other similar functions from the CL.
After some profiling, I realized that it was the plot_progress function that was slowing things down. Turning that off speeds things up.

@calebweinreb
Copy link
Owner

Got it! Did you also find that load_data was slower, though? That would still be unexplained

@r-shruthi11
Copy link
Author

Ack, you're right. load_data was also slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants