Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undesirable behavior of ResamplePath and TOTP for zero-length paths #5

Open
3 tasks
calderpg opened this issue Sep 18, 2020 · 1 comment
Open
3 tasks
Assignees

Comments

@calderpg
Copy link
Owner

ResamplePath will shorten path segments with zero distance, i.e. [[1, 2], [1, 2]] becomes [[1, 2]]. This is normally desirable, but TOTP requires paths with at least two waypoints, and will segfault when given a path with only one waypoint. Additionally, TOTP appears to produce nonsense trajectories for zero-length paths.

Action items:

  • Decide if ResamplePath should ever resample a path to a single waypoint, and correct if not.
  • Add safety check in TOTP parametrization for single-waypoint paths (and/or replace offending operator [] with .at() to get such bounds checks).
  • Assess TOTP trajectories for zero-length paths and see if fixes are necessary.
@calderpg calderpg self-assigned this Sep 18, 2020
@calderpg
Copy link
Owner Author

For the near term, TOTP has been modified to throw if paths with less than two waypoints are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant