Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cases] error handling and feedback improvements #91

Merged
merged 28 commits into from
Jun 19, 2024
Merged

[cases] error handling and feedback improvements #91

merged 28 commits into from
Jun 19, 2024

Conversation

ronniebeggs
Copy link
Collaborator

What's new in this PR

Description

  • Create a standardized loading component instead of the "loading…" text.
  • Add queryLoading functionality to all buttons in the case flow.
  • Standardize error messages for case context functions.
  • Refactor case context to reduce redundant database queries.
  • Update routing logic to reduce query reloads.
  • Add image placeholders while loading.
  • Create fullStopErrorHandler for catching uncaught errors and raising native Alert.

Screenshots

Next steps

  • Create button to prompt camera permissions enable message.
  • Add toast message to /AllCases screen for eligibility/adding/deleting case feedback.
  • Consider building a basic error handling screen for the full stop error handler.

Relevant Links

Online sources

Fault Tolerance

CC: @ronniebeggs

@ronniebeggs
[feat] add loading feedback to qr code scanner button.
7a9018d
@ronniebeggs
[feat] add loading feedback to AddCase screen button.
f3d1b6d
@ronniebeggs
[feat] add loading feedback to confirm eligibility button.
a874f5d
@ronniebeggs
[feat] loading feedback for ineligibility and opt out actions.
2fa8eb2
@ronniebeggs
[feat] add loading feedback to file claim action.
8416c6e
@ronniebeggs
[fix] restructure CaseScreen and CaseContext to prevent unnecessary r…
153a51d 
…eloads.
@ronniebeggs
[refactor] integrate getCaseStatus with case context.
9126675
@ronniebeggs
[refactor] case status -> claim status.
0bfc885
@ronniebeggs
[feat] create basic loading spinner component.
c0697e4
@ronniebeggs
[feat] replace loading text with spinner on all screens.
e1ce069
@ronniebeggs
[feat] add light grey background as image placeholder.
c1ad184
@ronniebeggs
[refactor] loading screen component.
0777283
@ronniebeggs
[refactor] move add/remove case to case context.
ec7372c
@ronniebeggs
[cleanup] add ios/ to gitignore.
357582f
@ronniebeggs
[cleanup] use case context function for fetching context data.
9db2d0d
@ronniebeggs
[cleanup] remove unused import.
2b7c77f
@ronniebeggs
[wip][feat] configure timeout behavior for poor network connection se…
5e1f81a 
…ttings.
@ronniebeggs
[refactor] move resetAndPushToRoute to auth queries; cleanup.
d78f353
@ronniebeggs
[feat] create resetAndPushToHome that navigates to the home screen (r…
97bfc9c 
…elative to whether they're logged in or not).
@ronniebeggs
[feat] create wip full stop error function; refactor screen loading c…
1aff6c6 
…omponent.
@ronniebeggs
[cleanup] misc cleanup; update screen loading text for clarity.
5b2cf0b
@ronniebeggs
[cleanup] update doc strings.
a038cdd
@ronniebeggs
[feat] begin integrating error handler for case fetching functions.
eb9dd91
@ronniebeggs
[wip] continue adding error handling to case related screens.
db873b3
@ronniebeggs
[feat] add error handler to all case related screens.
0bdfb72
@ronniebeggs
[fix] case context code performance and clarity improvements.
88ce867
@ronniebeggs
[cleanup] misc refactoring and adding comments.
852b782
@ronniebeggs
[fix] resolve missing caseData on FileClaim screen.
15509bc
@ronniebeggs ronniebeggs self-assigned this Jun 19, 2024
@linear Linear
Copy link

linear bot commented Jun 19, 2024

IMP-100 Case Flow Error Handling and Feedback Improvements

@ronniebeggs ronniebeggs merged commit 3154f46 into main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ronniebeggs ronniebeggs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ronniebeggs