Philipye314/imp 2 qr code scanner #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMP-2 QR Code Scanner
Description Create a new branch by clicking the far right icon in the top right corner and pull from main: Create the QR Code Scanner. I will provide a dummy QR code to confirm that the QR Code Scanner works. The links below show the implementation V4V used last year but do a little bit of research and see if this is a best fit for us before starting! Let me (or anyone) know if you need any help along the way! Useful Links V4V Bar Code Scanner: Expo BarCodeScanner documentation: https://docs.expo.dev/versions/latest/sdk/bar-code-scanner/ Related PRs |
philipye314
force-pushed
the
philipye314/imp-2-qr-code-scanner
branch
from
efc251e
to
243119f
Compare
stephaniewong2
requested changes
Oct 10, 2023
src/app/(BottomTabNavigation)/Cases/QRCodeScanner/img/crosshair.png
Outdated
Show resolved
Hide resolved
* wip: intializing db * wip: fixing branch name * feat: intialized database * update to feature * fixed eslint errors * current supabase update * fixed client initialization * feat: intialize database is done * changed touchableopactiy imports --------- Co-authored-by: foloy <[email protected]> Co-authored-by: Stephanie Wong <[email protected]>
stephaniewong2
requested changes
Oct 11, 2023
stephaniewong2
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Created barcode scanner that reads information from a barcode and displays it on screen
Screenshots
(SORRY IDK WHY ITS SO BIG)
How to review
Open the QRCodeScanner subfolder in app/BottomTabNavigation/QRCodeScanner. The display of the camera and the crosshair is all dictated by CSS in the corresponding styles.ts file. I'd like some feedback on how exactly the crosshair should be displayed (I. e. should it be around the camera window? should the camera window take up the full screen, with the crosshair overlayed on top?). Should just be reviewed as a final commit. Haven't been able to test user permissions because expo never asks me for camera permission, but I wrote some basic logic to handle that -- not sure if that's part of my job. Otherwise the QRCodeScanner should be functional and you'll know it works if the dummy text below the crosshair updates.
Next steps
Relevant Links
Online sources
Related PRs
CC: @stephaniewong2