Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search] Update search styling #74

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Conversation

Marcoss28
Copy link
Collaborator

What's new in this PR

  • Search Screen styling updated
  • Search screen view implemented for no search results
  • Search screen implemented for no recent searches and stories

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/search-Update-search-styling-b775b58af93b41dfa1c685ce82cc19bc

Online sources

N/A

Related PRs

N/A

How to review

Go to the search screen and check screen when there are no recent searches/stories and when there are. Now check the screen after having something in the search bar when there are and aren't search results.

Next steps

N/A

Tests Performed, Edge Cases

  • Search and view a story to check recently viewed searches/stories screen displays correctly
  • Clear all recently viewed searches and stories and screen should change
  • Now search a random input to check that the proper search screen pops up when no search results can be found

Screenshots

RPReplay_Final1711498428.mp4

CC: @adityapawar1

Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fire. couple styles change before we can merge!

src/app/(tabs)/search/index.tsx Outdated Show resolved Hide resolved
src/app/(tabs)/search/index.tsx Outdated Show resolved Hide resolved
src/app/(tabs)/search/index.tsx Outdated Show resolved Hide resolved
src/app/(tabs)/search/styles.ts Show resolved Hide resolved
src/app/(tabs)/search/styles.ts Outdated Show resolved Hide resolved
src/components/RecentSearchCard/styles.ts Outdated Show resolved Hide resolved
src/components/RecentSearchCard/styles.ts Show resolved Hide resolved
src/app/(tabs)/search/index.tsx Outdated Show resolved Hide resolved
src/app/(tabs)/search/styles.ts Outdated Show resolved Hide resolved
src/app/(tabs)/search/styles.ts Outdated Show resolved Hide resolved
@adityapawar1 adityapawar1 changed the title Marcos/update search styling [search] Update search styling Mar 29, 2024
Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect! great job

Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops meant to review the other pr

Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! ready to merge

@adityapawar1 adityapawar1 merged commit 3e4edab into main Apr 5, 2024
2 checks passed
@adityapawar1 adityapawar1 deleted the marcos/update-search-styling branch April 5, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants