[auth] Style onboarding screen #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8fdf6d804782cc39f9deb904f296cf6296e68e31. Mistake yes
…ing"" This reverts commit 7c2d1b5595e1be593c50752d0518bb9c37fb8ade.
…on, and styled according to Figma
…led onboarding screen
|
is this background the same on the figma? it looks more grey |
I think I fixed it! |
adityapawar1
requested changes
Mar 16, 2024
…int/girls-write-now into justin/style-onboarding-screen
adityapawar1
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
I added the birthday input button, but it hasn't been implemented. Implemented the Skip For Now option, and styled the screen. The bottom buttons are starting to go off the screen because everything is kinda just one block right now. I think in the figma, the information input boxes are in their own scroll so it doesn't move the bottom? I was struggling to figure out how to do that though. I also made it so that the user is able to press Update Profile if they have filled out at least one of the four input boxes.
Relevant Links
Notion Sprint Task
https://www.notion.so/calblueprint/auth-Style-onboarding-screen-b5de52766dad41d586ed21635d95fa53
Online sources
Related PRs
How to review
Signup for a new account to get to the onboarding screen.
Next steps
Tests Performed, Edge Cases
Screenshots
CC: @adityapawar1