Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

696 - Fix table method to add the table to array as phinx does #711

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

ajibarra
Copy link
Member

Fixes #696

After creating table, it needs to be added to array to ensure postFlightCheck reports pending actions in tables. Phinx does that in table method but for some reason the override was missing it.

I have sent a PR to cakephp/phinx to ensure postFlightCheck is executed before commiting the transaction to avoid getting the exception after damage is done.

cakephp/phinx#2272

@ajibarra
Copy link
Member Author

Not sure why postgres is not working. Will wait some time and try to run workflow again:

psql: error: connection to server at "127.0.0.1", port 5432 failed: server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.

markstory added a commit that referenced this pull request Apr 27, 2024
The builds on that branch have been reliable and hopefully this fixes
the build issues we've seen in #711
@ajibarra
Copy link
Member Author

Not sure why postgres is not working. Will wait some time and try to run workflow again:

psql: error: connection to server at "127.0.0.1", port 5432 failed: server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.

Fixed! Thanks @markstory!

@markstory markstory merged commit 3de99c3 into cakephp:4.x Apr 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: [no-phinx] Show warning if table instance has actions attached which haven't been executed
2 participants