-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to "flag" queries #476
Comments
I like this idea |
I just looked around a bit to see how this could be implement, but I haven't found a nice way yet. The |
👍 @lorenzo Any ideas here? |
I think this is a great idea, and was going to open a new ticket for something like this. Except my idea was to "tag" queries so that we could filter them in the SQL log. There would be the default view of the SQL log in chronological order, but across the top would be checkboxes for each group. Unchecking a group would hide those queries from the log. It would just be a visual hiding of matching DOM elements. I would also prefer to update the Query object interface to allow a more verbose way of tagging. It just makes it easier to work with.
A query can be tagged with multiple tags. I would also add tags for internal queries like the "SHOW INDEXES" and "SHOW COLUMNS" that are frequently done by the core. Maybe just tag them with "cake" or something like that. Also (another idea) the models could auto tag the model name when the query object is created. I think this could be a very useful feature. |
Tagging queries is an interesting idea. Should the tags be an map instead of a list? That would allow us to record metadata about the queries more effectively. |
I'm not sure that I understand, but keep in mind two tags could share same query object. |
Something like |
The new CakePHP 5.x tracing query execution feature could be of help to some degree. |
Is there someone who wants to provide a PR here? |
This issue is stale because it has been open for 120 days with no activity. Remove the |
It would be nice if it would be possible to mark SQL queries in some way to find them in the Panel if there are many of them. Maybe one could abuse
applyOptions
for this:Maybe queries could be even automatically tagged based on their origin (primary/secondary).
I tried a quick attempt to hack in this myself, but this seemed not that easy, unfortunately.
The text was updated successfully, but these errors were encountered: