-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChronosInterval #444
Comments
I sth like this viable? |
Given how thorny |
Downside is that the types on methods wouldnt work, if something expects a native one. |
Which is why we'd have a |
Why is that?
The suggested method doesnt exist in the code
I would recommend we keep this method as it is useful and better than using the native DateInternal class and its methods.
E.g. (string) casting to the native format is super important IMO.
I see that 3449eca dropped it as there were some issues with the native class and compatibility.
I have the same issue when trying to actually create any kind of improved wrapper around it.
Maybe instead of extending it, we could encapsulate it using the proxy pattern?
But according to e.g. https://github.com/pauci/datetime/blob/master/src/DateInterval.php it should work with extension.
The text was updated successfully, but these errors were encountered: