Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing methods & breaking BC #110

Open
piperone opened this issue Oct 4, 2018 · 2 comments
Open

Removing methods & breaking BC #110

piperone opened this issue Oct 4, 2018 · 2 comments

Comments

@piperone
Copy link

piperone commented Oct 4, 2018

I'm a bit perplexed with regards to your recent releases in which you chose to drop the LaravelCollective-dep. Removing deps is all well and good, but gouging out two of your existing methods without updating your major-version number, is bound to introduce problems for users of your package. From the outside, I get the impression that this was a careless move and I hope you will consider backwards compatibility more next time (i.e. v3.2.1 should have been v4.0.0).

Also, your docs still talk about the attribute-method that was removed.

Thanks for all your work, keeping this package up to date!

@kaidesu
Copy link
Contributor

kaidesu commented Oct 10, 2018

Ha. You're right - should have been a major release vs. minor - I'll get this rectified, thanks for the feedback!

I'm also in the process of migrating and cleaning up the documentation for all packages to a central location. I've removed the link to the attribute methods in the documentation navigation for now.

@jigs1212
Copy link

What is the alternate we should use for attributes.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants