Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points should accept subsets of the Space Dimensions as values #50

Open
danlessa opened this issue Jan 26, 2023 · 1 comment
Open

Points should accept subsets of the Space Dimensions as values #50

danlessa opened this issue Jan 26, 2023 · 1 comment
Assignees
Labels
wontfix This will not be worked on
Milestone

Comments

@danlessa
Copy link
Member

danlessa commented Jan 26, 2023

Providing int values will generate an Schema Mismatch on this case even though they're subset of the float type.:

data = {"x": -5, "y": 7}

@space
class CartesianPlane:
    x:float
    y:float

my_point = Point(CartesianPlane, data)

CartesianPlaneDot = CartesianPlane.rename_dims({'x':'dx', 'y':'dy'})
@DrCatman DrCatman added this to the MISO Alpha milestone Jan 27, 2023
@DrCatman DrCatman moved this from To do to Done in cadCAD Reference Implementation Feb 10, 2023
@DrCatman DrCatman added the wontfix This will not be worked on label Feb 10, 2023
@emanuellima1
Copy link
Member

We are considering int not being a subset of float to give stronger type safety for simulations. So the schema mismatch between int and float is desired behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Development

No branches or pull requests

3 participants