Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-Peer Review - Week 4, Module 2 #11

Open
Sanja969 opened this issue Jun 14, 2022 · 0 comments
Open

Peer-to-Peer Review - Week 4, Module 2 #11

Sanja969 opened this issue Jun 14, 2022 · 0 comments

Comments

@Sanja969
Copy link

You did a great job. I like your style and how you did your testing. But there is always something to be improved:

  • Your code could be more DRY and KISS, for example, in testing you repeated some stuff that you already had in your functions that you wanted to test.
  • It would be better if you added an event listener on your edit - three points button, when you click there your task should be editable, not before that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant