Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monomorphic.min function is slow #452

Closed
FardaleM opened this issue Jun 3, 2024 · 2 comments · Fixed by #453
Closed

Monomorphic.min function is slow #452

FardaleM opened this issue Jun 3, 2024 · 2 comments · Fixed by #453

Comments

@FardaleM
Copy link
Collaborator

FardaleM commented Jun 3, 2024

I realised that the min function from the Monomorphic module is using the polymorphic compare and is therefore slower than it should be.
@FardaleM
Copy link
Collaborator Author

FardaleM commented Jun 3, 2024

I am planning to check this when I got some time.

c-cube added a commit that referenced this issue Jun 3, 2024
@c-cube
perf: use a monomorphic impl for CCMonomorphic.{min,max}
9a14cab 
close #452
@c-cube c-cube mentioned this issue Jun 3, 2024
Merged
@c-cube
Copy link
Owner

c-cube commented Jun 3, 2024

can you look at #453?

c-cube added a commit that referenced this issue Jul 9, 2024
@c-cube
perf: use a monomorphic impl for CCMonomorphic.{min,max}
60bd3ae 
close #452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: use a monomorphic impl for CCMonomorphic.{min,max} c-cube/ocaml-containers
2 participants
@c-cube @FardaleM