From 7cfada7a6d79db3b2bc6adced26871908865dc61 Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Wed, 13 Sep 2023 12:28:52 -0400 Subject: [PATCH] Remove ramaining stray CHIP_CRYPTO_HSM checks. These were apparently missed in https://github.com/project-chip/connectedhomeip/pull/27130. --- examples/contact-sensor-app/nxp/k32w/k32w0/main/AppTask.cpp | 3 --- examples/lighting-app/nxp/k32w/k32w0/main/AppTask.cpp | 3 --- examples/lock-app/nxp/k32w/k32w0/main/AppTask.cpp | 3 --- src/credentials/CHIPCert.cpp | 3 --- src/credentials/FabricTable.h | 3 --- .../nxp/crypto/se05x/CHIPCryptoPALHsm_se05x_spake2p.cpp | 2 +- 6 files changed, 1 insertion(+), 16 deletions(-) diff --git a/examples/contact-sensor-app/nxp/k32w/k32w0/main/AppTask.cpp b/examples/contact-sensor-app/nxp/k32w/k32w0/main/AppTask.cpp index fbd0a6877e3a45..24d3f4cf4af629 100644 --- a/examples/contact-sensor-app/nxp/k32w/k32w0/main/AppTask.cpp +++ b/examples/contact-sensor-app/nxp/k32w/k32w0/main/AppTask.cpp @@ -51,9 +51,6 @@ #include "PWR_Interface.h" #include "app_config.h" -#if CHIP_CRYPTO_HSM -#include -#endif #ifdef ENABLE_HSM_DEVICE_ATTESTATION #include "DeviceAttestationSe05xCredsExample.h" #endif diff --git a/examples/lighting-app/nxp/k32w/k32w0/main/AppTask.cpp b/examples/lighting-app/nxp/k32w/k32w0/main/AppTask.cpp index 5f67ac9f58b91c..cb6a5d53f3a2bd 100644 --- a/examples/lighting-app/nxp/k32w/k32w0/main/AppTask.cpp +++ b/examples/lighting-app/nxp/k32w/k32w0/main/AppTask.cpp @@ -52,9 +52,6 @@ #include "LEDWidget.h" #include "app_config.h" -#if CHIP_CRYPTO_HSM -#include -#endif #ifdef ENABLE_HSM_DEVICE_ATTESTATION #include "DeviceAttestationSe05xCredsExample.h" #endif diff --git a/examples/lock-app/nxp/k32w/k32w0/main/AppTask.cpp b/examples/lock-app/nxp/k32w/k32w0/main/AppTask.cpp index 9e6afc3e77b6f1..e8513334fb96d7 100644 --- a/examples/lock-app/nxp/k32w/k32w0/main/AppTask.cpp +++ b/examples/lock-app/nxp/k32w/k32w0/main/AppTask.cpp @@ -41,9 +41,6 @@ #include "PWR_Interface.h" #include "app_config.h" -#if CHIP_CRYPTO_HSM -#include -#endif #ifdef ENABLE_HSM_DEVICE_ATTESTATION #include "DeviceAttestationSe05xCredsExample.h" #endif diff --git a/src/credentials/CHIPCert.cpp b/src/credentials/CHIPCert.cpp index 1c0e9d7b281f0b..927030b11ff929 100644 --- a/src/credentials/CHIPCert.cpp +++ b/src/credentials/CHIPCert.cpp @@ -45,9 +45,6 @@ #include #include #include -#if CHIP_CRYPTO_HSM -#include -#endif namespace chip { namespace Credentials { diff --git a/src/credentials/FabricTable.h b/src/credentials/FabricTable.h index 621ec354e50084..a1181ba4560843 100644 --- a/src/credentials/FabricTable.h +++ b/src/credentials/FabricTable.h @@ -32,9 +32,6 @@ #include #include #include -#if CHIP_CRYPTO_HSM -#include -#endif #include #include #include diff --git a/src/platform/nxp/crypto/se05x/CHIPCryptoPALHsm_se05x_spake2p.cpp b/src/platform/nxp/crypto/se05x/CHIPCryptoPALHsm_se05x_spake2p.cpp index a60209f065aade..f1b13a54458cd6 100644 --- a/src/platform/nxp/crypto/se05x/CHIPCryptoPALHsm_se05x_spake2p.cpp +++ b/src/platform/nxp/crypto/se05x/CHIPCryptoPALHsm_se05x_spake2p.cpp @@ -351,7 +351,7 @@ CHIP_ERROR Spake2pHSM_P256_SHA256_HKDF_HMAC::ComputeRoundOne(const uint8_t * pab constexpr bool sw_rollback_verifier = false; #endif -#if ((CHIP_CRYPTO_HSM) && (!ENABLE_SE05X_SPAKE_PROVER)) +#if !ENABLE_SE05X_SPAKE_PROVER const bool sw_rollback_prover = (role == chip::Crypto::CHIP_SPAKE2P_ROLE::PROVER); #else constexpr bool sw_rollback_prover = false;