From 18661532cf2a521cb56bbe96e2b2999d337591be Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Wed, 6 Sep 2023 12:26:11 -0400 Subject: [PATCH] Fix slow test skipping in CI. CI does "--exclude-tags SLOW", but it was not specifying any "--include-tags", so the harness overwrote the "--exclude-tags" value and we were in fact running the slow tests when we did not want to be. --- scripts/tests/run_test_suite.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tests/run_test_suite.py b/scripts/tests/run_test_suite.py index dc126b4e471314..643f13ce4d92af 100755 --- a/scripts/tests/run_test_suite.py +++ b/scripts/tests/run_test_suite.py @@ -169,7 +169,7 @@ def main(context, dry_run, log_level, target, target_glob, target_skip_glob, # If just defaults specified, do not run manual and in development # Specific target basically includes everything - if 'all' in target and not include_tags: + if 'all' in target and not include_tags and not exclude_tags: exclude_tags = { TestTag.MANUAL, TestTag.IN_DEVELOPMENT,