-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builder with MonthMatch
#44
Comments
I think this is the function I would want:
This is similar to the Concerning exporting
as a part of its public API, and then |
Great! The only concern I had for the |
For anyone browsing this issue, an example of the desired format (taken from
|
It would be helpful to have a builder with which you could use
MonthMatch
.For example, in
co-log
we needed to have months in 3-letter format (like Dec, Jan, etc.), so we implemented a builder manually:co-log/co-log#166
If you think that it makes sense to have in the
chronos
library, I could help with the implementation as soon as we agree on the API (to have an additional field in theDatetimeFormat
or to explicitly take aMaybe (MonthMatch a)
as an argument, or something else?).Let me know what do you think.
Oh, by the way, while implementing the builder, I have noticed that functions like
zeroPadDayOfMonth
etc. are not exported. Would you consider exporting them, or there is a reason not to do that? (if this question if offtopic for this issue I totally understand and could create a new one if you think that this idea makes sense at all).The text was updated successfully, but these errors were encountered: