Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the MemoryCreator trait to support immovable memories #9568

Open
alexcrichton opened this issue Nov 5, 2024 · 0 comments · May be fixed by #9577
Open

Refactor the MemoryCreator trait to support immovable memories #9568

alexcrichton opened this issue Nov 5, 2024 · 0 comments · May be fixed by #9577

Comments

@alexcrichton
Copy link
Member

alexcrichton commented Nov 5, 2024

In #9569 the memory_may_move configuration knob was plumbed into memories themselves to limit the growth of the memory. This knob is not surfaced in the custom MemoryCreator trait, however, and memories created from that trait are pessimistically assumed to always possibly move in memory. This issue is intended to track refactoring this trait to improve this situation and enable plumbing the information a bit further.

Ideally the MemoryCreator and RuntimeMemoryCreator traits are merged. After looking at this for a bit this'll require some deeper refactoring to keep things making sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant