Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmparser::validator::ComponentState::validate_and_register_named_types should return Result instead of bool #1486

Open
rylev opened this issue Apr 4, 2024 · 0 comments

Comments

@rylev
Copy link
Contributor

rylev commented Apr 4, 2024

Right now the validator uses wasmparser::validator::ComponentState::validate_and_register_named_types to ensure that a given extern only refers to named types, but it only returns a bool instead of a Result. This makes debugging much more difficult as one cannot be sure what the actual issue is without using a debugger or patching in a local copy of wasmparser to add debug logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant