-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async export support #112
Comments
I do not understand the internals of the event loop yet. I just wanted to note that this seems like a regression in #111. The behavior on the latest release seems to be the expected behavior where the guest seems to run until all the async tasks complete. |
I think it's actually a bug that it was working before actually as the event loop architecture in StarlingMonkey has since changed. The technical counter-argument is that draining the event loop entirely risks allowing |
I think this makes sense to do, yes. An additional or alternative thing we could consider is to expose a way for embedders to spin the event loop explicitly, or at least so explicitly register interest. |
We (https://github.com/golemcloud/) are quite excited about this and the fetch support, so as an experiment with this idea we merged the current pending related PRs into forks (both on StarlingMonkey and ComponentizeJs), and then moved around a bit the interest markers and exposed "runEventLoop". This way after making a fetch request we can call explicitly the event loop, and by the time it returns, the fetch and related promises are nicely resolved and do work (so we can return them synchronously), which is quite promising, and would be something that we would be happy to live with until this topic evolves more. On the other hand, repeated (10-100) calls to fetch in the same exported call and / or specific payload sizes (depending on the specific code) can trigger errors in the post_call phase, specifically in cabi_free. With node it results in "RuntimeError: memory access out of bounds" and similar errors are happening with wasmtime. I do see that there is also a probably related issue on how the current "gc" is implemented (#1), and probably this is a bit more complicated topic then i think, but wanted to ask if you might be able to provide any pointers on how one should continue debugging such errors or whether this is something that expected for now or if not, then it could be also added as a test case to the fetch ones. |
This is now supported in #131. |
When implementing sync component model functions as async exports in JS (functions returning a promise), we should integrate with the event loop by:
increase_event_loop_interest()
before awaiting the promise anddecrease_event_loop_interest()
on the promise then and catch handlers.run_event_loop
in the main export function wrapper if there is event loop interest to resolve the return valueThis is just a rough outline off the top of my head but hopefully it helps.
The text was updated successfully, but these errors were encountered: