Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT: Vault Interface to Web App #284

Closed
bigalgeorge opened this issue Oct 9, 2019 · 11 comments
Closed

ENHANCEMENT: Vault Interface to Web App #284

bigalgeorge opened this issue Oct 9, 2019 · 11 comments

Comments

@bigalgeorge
Copy link

Since vault needs to be opened by extension, its logical the web interface be expanded to include such functions as full search, edit fields, multiselect fields for move/deletion etc, export/import and so on, doing away with the buttercup application. If others concur, perhaps add their pennyworth here as well thanks a lot.

(google 'alistair george nz programmer'). I dont program any more due health but if you would like, I would be happy to put together a helpfile/methods suggestion for intended web app, if that may help.

@ldexterldesign
Copy link

ldexterldesign commented Oct 10, 2019

Since vault needs to be opened by extension

To clarify:

  • Vault (i.e. desktop/mobile) is opened by desktop/mobile - use case is I'm referencing a bank sort code
  • Vault (i.e. web) is opened by browser extension - use case is I'm logging in to a website

I think the plan is to make Buttercup a manager for all [t]ypes (excuse pun) of private data not just web credentials. Based on this one could argue a non-browser-based app makes sense (too).

FYI before I migrated to Buttercup, [D]ashlane, my previous private data manager, was in the process of migrating from desktop app to (extension-based) web app; I suspect because it suited their subscription payment model. Buttercup doesn't have a business/payment model yet.

Technically there are probably a plethora of reasons end-users won't care about but I presume it's because Buttercup uses [N]ode and requires [E]lectron to deploy this code (Node is server-side and won't run in browser (e.g. as extension)). Also an Electron build can be thrown at cross-platform desktop and mobile. I may be wildly wrong!

Regards

e: https://electronjs.org/
n: https://nodejs.org/en/
t: buttercup/buttercup-desktop#540

@perry-mitchell
Copy link
Member

Perhaps I'm completely misunderstanding the request (apologies if I am!) - I re-read this issue and the last twice, but I can't get my head around exactly what you're after. We have a vault interface in the extension now:

image

Which can be opened by going through the menu:

image

Through this interface you can edit, search etc.. I'll readily admit that it's maybe not the easiest to find. Is that what you mean? 😅

@bigalgeorge
Copy link
Author

bigalgeorge commented Oct 12, 2019

Yes that is what I mean BUT unless Im having a bad head day, the only search within the web interface is a filter which actually is not a search at all please read my OP below:
//its logical the web interface be expanded to include such functions as full search, edit fields, multiselect fields for move/deletion etc, export/import and so on, doing away with the buttercup application.
Granted, edit fields works, but there could be enhancements to that.

Regards seach; agreed you do need a global search, but the url field should have priority IMHO. EG rarely we need to find something in Notes, but mostly we need to find a destination url. See my OP which provides search finding a 'kiwi' in the notes, not in a 'kiwi' url, where the required url was much further down the list.
Hope this helps.

@bigalgeorge
Copy link
Author

I think the search you are referring to is in the browser extension, not the web app; you need both.

@bigalgeorge
Copy link
Author

Still referring to the web interface; consider the root folder (optionally) could include the contents of all the folders below as well? Reasoning being alphabetized full contents helps editing. However, if doing so, I recommend it is only optional; not fixed. EG checkbox under GROUPS [x] Global Root

@perry-mitchell
Copy link
Member

perry-mitchell commented Oct 12, 2019

Thanks for clarifying, though I feel I’m still missing some subtleties. For me the term web app is confusing as really everything we have besides the mobile app are web apps. We have the desktop application and this, the extension, but I’m not sure distinguishing which is which is important here - we’re taking about the browser extension and I’m not entirely sure what’s being asked for.

We have the vault mgmt interface in the extension so that using the desktop application isn’t necessary. Search is an aspect of both platforms and one we’re intending on improving- to my recollection the desktop is already using fuzzy search, albeit a more generic one. I agree with angling the one in this extension more towards urls as that’s what you’re really doing in the browser.

If the difference in features comes down to import/export and improved search, perhaps it’s better if we separate those into separate issues instead of aggregating them here? If I’ve missed something else forgive me, it’s late and I’ve been parsing issues for a while now 😅

@bigalgeorge
Copy link
Author

Thanks your reply what Im referring to as 'web app' is the form thats instantiated when you click on the browser extension/vaultname (unlocked)

@perry-mitchell
Copy link
Member

the root folder (optionally) could include the contents of all the folders below as well

Well the root folder/node is not selectable, which I prefer - it'd be out of place having a single root node always visible in my opinion. We will definitely work in something with the search field though, so that all entries might be shown once it's selected.

@perry-mitchell
Copy link
Member

@bigalgeorge Thanks for the clarification. I'll address your points in more detail:

full search

Planned, that's a must for us!

edit fields

Already possible.

multiselect fields for move/deletion etc

Great idea!

export/import

Possible, but tricky. Not sure how easy this is when our importer is not designed for the browser. It uses hardcore OS-level crypto in some regards that can't currently be ported to the browser without substantial work. I'll leave this one in discussion for now.

the url field should have priority

As mentioned in my last comment, I agree here. Definitely makes sense for a browser extension.

I'll go through and match up issues.

@perry-mitchell
Copy link
Member

Searching: buttercup/ui#24
Multi-select: buttercup/ui#25

Currently the entire vault UI used here is housed over at this repo: https://github.com/buttercup/ui

It will soon be introduced to the desktop app, so work done there will be reflected on multiple platforms.

I'll close this as I feel that directing these ideas into individual issues will make the work more approachable. If you come up with more, please don't hesitate to create them here (if browser-only) or in the UI repo (for generic platform features). Thanks!

@ldexterldesign
Copy link

ldexterldesign commented Oct 12, 2019

Glad I interjected - I did not know the desktop app was superfluous

Will explore the browser extension UI more and look forward to the (desktop app) update

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants