From 6ac80db02c6244bffebd3f52419ebc162415e88c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 3 Dec 2024 23:04:10 +0000 Subject: [PATCH] simplify the use of toolexecCmd in reverse The list flags are entirely unused, so they can be omitted. The only argument that matters is the package argument to load. While here, update the TODO, as it no longer applies. --- reverse.go | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/reverse.go b/reverse.go index eb69a8ac..85926f28 100644 --- a/reverse.go +++ b/reverse.go @@ -33,16 +33,9 @@ One can reverse a captured panic stack trace as follows: } pkg, args := args[0], args[1:] - listArgs := []string{ - "-json", - "-deps", - "-export", - } - listArgs = append(listArgs, flags...) - listArgs = append(listArgs, pkg) - // TODO: We most likely no longer need this "list -toolexec" call, since - // we use the original build IDs. - _, err := toolexecCmd("list", listArgs) + // We don't actually run `go list -toolexec=garble`; we only use toolexecCmd + // to ensure that sharedCache.ListedPackages is filled. + _, err := toolexecCmd("list", []string{pkg}) defer os.RemoveAll(os.Getenv("GARBLE_SHARED")) if err != nil { return err