Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: remove "Advanced" button when web3 is injected #9

Open
PaulRBerg opened this issue Sep 29, 2019 · 2 comments
Open

Suggestion: remove "Advanced" button when web3 is injected #9

PaulRBerg opened this issue Sep 29, 2019 · 2 comments

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Sep 29, 2019

When I open the burner in a web3-less browser, the Advanced page shows three buttons: "Show PK", "Copy PK" and "Hide PK".

If I open the burner in a browser with MetaMask enabled, the same page shows up as empty.

Screen Shot 2019-09-28 at 20 01 22

Ideally, there would be no "Advanced" button when web3 is injected - and perhaps a hint that you should switch to "dai.poa.network" would help.

@dmihal
Copy link
Collaborator

dmihal commented Sep 29, 2019

The advance page will stay, as there may be more elements added to that page. However, the advance page should definitely explain that Metamask is being used, and the private key can not be used.

@PaulRBerg
Copy link
Contributor Author

The advance page will stay, as there may be more elements added to that page

Makes sense!

Hope it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants