Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using native secret storage #5

Open
shocklateboy92 opened this issue Sep 18, 2022 · 5 comments
Open

Using native secret storage #5

shocklateboy92 opened this issue Sep 18, 2022 · 5 comments

Comments

@shocklateboy92
Copy link

I noticed in your readme that you plan to support storing secrets in an encrypted file.
You should consider delegating that to secret storage mechanisms of the operating system (e.g. gnome-keyring or kwallet). Will mean less work for you, and less security bugs 😄

https://specifications.freedesktop.org/secret-service/latest/

@Mart-Bogdan
Copy link

But this software supports windows (and mac in future).

Dbus and freedesktop don't want to port on windows, or at least to provide binaries.

@shocklateboy92
Copy link
Author

Good point. But there is a windows equivalent:
https://github.com/danieljoos/wincred

@cmdli
Copy link
Contributor

cmdli commented Sep 19, 2022

This is definitely a potential feature down the line, though right now I am prioritizing getting basic Mac support up and running. I do see the value in hardened credential storage on each platform, though I also want to allow people to be able to export/transfer credentials even in that case.

@shocklateboy92
Copy link
Author

That makes perfect sense 🙂
Of course, I haven't done any MacOS development, but I assumed it would take drastically less code/time to use keychain than to write the storage mechanism yourself. 🤷
https://github.com/keybase/go-keychain

@jo-vf
Copy link

jo-vf commented Oct 20, 2022

To me the most important aspect of this project is, that it can address the drawback of not being able to back up your keys. Depending upon the "native store" chosen you might again loose this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants