We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveSupport::TestCase
setup
teardown
Looks like Bullet Train is using minitest's def setup and def teardown where users must remember to call super manually.
def setup
def teardown
super
ActiveSupport::TestCase includes setup do (or setup :some_setup_method) and teardown do where users won't need to remember that detail.
setup do
teardown do
I think we should swap to the more Rails conventional version.
References: https://github.com/search?q=repo%3Abullet-train-co%2Fbullet_train%20%2Fdef%20setup%2F&type=code https://github.com/search?q=repo%3Abullet-train-co%2Fbullet_train+%2Fdef+teardown%2F&type=code
cc @jagthedrummer
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Looks like Bullet Train is using minitest's
def setup
anddef teardown
where users must remember to callsuper
manually.ActiveSupport::TestCase
includessetup do
(or setup :some_setup_method) andteardown do
where users won't need to remember that detail.I think we should swap to the more Rails conventional version.
References:
https://github.com/search?q=repo%3Abullet-train-co%2Fbullet_train%20%2Fdef%20setup%2F&type=code
https://github.com/search?q=repo%3Abullet-train-co%2Fbullet_train+%2Fdef+teardown%2F&type=code
cc @jagthedrummer
The text was updated successfully, but these errors were encountered: