Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do Windows-based buildpackages look like? #604

Closed
jromero opened this issue May 4, 2020 · 2 comments
Closed

What do Windows-based buildpackages look like? #604

jromero opened this issue May 4, 2020 · 2 comments
Labels
os/windows type/research Issue intended to be exploratory.

Comments

@jromero
Copy link
Member

jromero commented May 4, 2020

Description

On WCOW, what should pack package-buildpack yield?

Considerations

  • .cnb file
    • We use GGCR's oci-layout functionality to create an OCI image which has no OS/Arch attribution.
  • image
    • There is no such thing as a "scratch" image for Windows
  • Do we need to consider the potential of future registry/hive functionality?
@jromero jromero added type/research Issue intended to be exploratory. status/triage Issue or PR that requires contributor attention. os/windows labels May 4, 2020
@dfreilich dfreilich added status/discussion-needed Issue or PR that requires in-depth discussion. and removed status/triage Issue or PR that requires contributor attention. labels May 27, 2020
@micahyoung
Copy link
Member

The work so far on #840 suggests that we'll want:

Linux buildpackage image

  • The image's os property is linux
  • Image buildpack layers are tar files with entry paths at /cnb/buildpacks/...

Windows buildpackage image

  • The image's os property is windows
  • Image buildpack layers are tar files with entry paths at Files/cnb/buildpacks/...
  • Image shim base layer is a minimal set of layer files required to support pulling and storing buildpackages on a WCOW daemon using pack or docker

Linux buildpackage file

  • The Linux buildpackage image packaged as as a standard .cnb

Windows buildpackage file

  • The Windows buildpackage image packaged as a standard .cnb

Image shim base layer

This PR buildpacks/imgutil#64 describes it better, but there is a minimal layer we can generate and add to buildpackages to allow docker pull and imgutil.FromBaseImage(). This was created from based on moby and hcsshim codebases, and everything in the layer can be generated from scratch, using OSS tools, at runtime with imgutil on any OS.

@dfreilich dfreilich removed the status/discussion-needed Issue or PR that requires in-depth discussion. label Feb 3, 2021
@jromero
Copy link
Member Author

jromero commented Mar 3, 2021

@micahyoung if I'm not mistaken, this issue can be closed due to the implementation of Windows Buildpackages.

Re-open if I'm missing something.

@jromero jromero closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os/windows type/research Issue intended to be exploratory.
Projects
None yet
Development

No branches or pull requests

3 participants