From 8f495dd7d0034f14cb863055e4f3bf8cb322ac7b Mon Sep 17 00:00:00 2001 From: Gordon Chan Date: Fri, 29 Jul 2022 14:52:14 +1200 Subject: [PATCH] Fix logging level from warn to error for consistency and correctness PIE-983 When an EOFError exception is raised, we want log at the 'error' level. This is also consistent with other exceptions that are rescued. --- lib/buildkite/test_collector/socket_connection.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/buildkite/test_collector/socket_connection.rb b/lib/buildkite/test_collector/socket_connection.rb index c34542f..7af0d59 100644 --- a/lib/buildkite/test_collector/socket_connection.rb +++ b/lib/buildkite/test_collector/socket_connection.rb @@ -78,7 +78,7 @@ def initialize(session, url, headers) rescue EOFError => e Buildkite::TestCollector.logger.warn("#{e}") if @socket - Buildkite::TestCollector.logger.warn("attempting disconnected flow") + Buildkite::TestCollector.logger.error("attempting disconnected flow") @session.disconnected(self) disconnect end