From 2c34694119dafe70c82eda88098ca2deab99e4ef Mon Sep 17 00:00:00 2001 From: "Naufan P. Rizal" Date: Thu, 1 Jun 2023 15:52:32 +1200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: niceking --- README.md | 2 +- lib/buildkite/test_collector/uploader.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 403eb5b..6eb2a4a 100644 --- a/README.md +++ b/README.md @@ -74,7 +74,7 @@ git push origin add-buildkite-test-analytics ``` ### VCR -If your test suites use [VCR](https://github.com/vcr/vcr) to interact with HTTP, you need to allow them to make an actual request to Test Analytics. +If your test suites use [VCR](https://github.com/vcr/vcr) to stub network requests, you'll need to modify the config to allow actual network requests to Test Analytics. ``` VCR.configure do |c| diff --git a/lib/buildkite/test_collector/uploader.rb b/lib/buildkite/test_collector/uploader.rb index 8a93911..a4312ed 100644 --- a/lib/buildkite/test_collector/uploader.rb +++ b/lib/buildkite/test_collector/uploader.rb @@ -46,8 +46,8 @@ def self.upload(data) retry end rescue StandardError => e - $stderr.puts "#{Buildkite::TestCollector::NAME} #{Buildkite::TestCollector::VERSION} experienced an error when sending your data, you may be missing some executions for this run." $stderr.puts e + $stderr.puts "#{Buildkite::TestCollector::NAME} #{Buildkite::TestCollector::VERSION} experienced an error when sending your data, you may be missing some executions for this run." end end end