Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict with's first type to be string #124

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Restrict with's first type to be string #124

wants to merge 3 commits into from

Conversation

thejcannon
Copy link
Contributor

The following pipeline errors with "Each element in a matrix.adjustments.with must be either a hash or a string":

steps:
  - label: "💥 Matrix build with adjustments"
    command: "echo"
    matrix:
      setup:
        - "2"
      adjustments:
        - with:
            - "2"
          soft_fail: true

thejcannon
thejcannon commented Dec 7, 2024
View reviewed changes
schema.json Outdated
Comment on lines 848 to 849
"type": "string",
"description": "List of existing or new elements for single-dimension Build Matrix",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW This kind of smells like a bug in the server-side pipeline validator (that it forces string and doesn't allow int or bool). I tried making the with: value an int and it did error, so this new schema is accurate.

@thejcannon thejcannon mentioned this pull request Dec 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thejcannon