Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some negative tests #85

Open
rogpeppe opened this issue Oct 31, 2024 · 1 comment
Open

add some negative tests #85

rogpeppe opened this issue Oct 31, 2024 · 1 comment

Comments

@rogpeppe
Copy link
Contributor

The tests currently have some examples that should validate, but does
not include any that should not validate. I checked by replacing
schema.json with the following:

{
  "$schema": "http://json-schema.org/draft-07/schema#"
}

and all the tests still passed, which does not seem ideal.

It would be good to have some negative tests too.

@angusfretwell
Copy link
Contributor

Hi @rogpeppe 👋

Thanks for raising the issue (and for your other recent contributions).

Agreed, the tests leave something to be desired.

I'll add this to our internal backlog, but we'd be happy to accept a PR if you like 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants