Update bazel and deps #1111
Update bazel and deps #1111
Conversation
keith
force-pushed
the
ks/update-bazel-and-deps
branch
from
261e913
to
984c7b5
Compare
|
|
||
| # gazelle:repository_macro dependencies.bzl%go_third_party | ||
| go_third_party() | ||
| pinned_maven_install() |
There was a problem hiding this comment.
this is still a bit of a mess since you cannot do some of these loads in the same bzl file where you pull in the dep, I think we'd have to create another file if we wanted to eliminate all the custom things done here.
| name = "pgv_pip_deps", | ||
| requirements = "@com_envoyproxy_protoc_gen_validate//python:requirements.in", | ||
| requirements_lock = "@com_envoyproxy_protoc_gen_validate//python:requirements.txt", |
There was a problem hiding this comment.
the old rule was removed the new one requires a lockfile
| go_third_party() | ||
|
|
||
| maven_install( | ||
| artifacts = PROTOBUF_MAVEN_ARTIFACTS, |
There was a problem hiding this comment.
this is required for protobuf java code now
| @@ -238,4 +238,5 @@ java_proto_gen_validate = rule( | |||
| "srcjar": "lib%{name}-src.jar", | |||
| }, | |||
| implementation = _java_proto_gen_validate_impl, | |||
| toolchains = ["@bazel_tools//tools/jdk:toolchain_type"], | |||
There was a problem hiding this comment.
| @@ -35,9 +35,5 @@ cc_test( | |||
|
|
|||
| py_proto_library( | |||
| name = "bar_py_proto", | |||
| srcs = ["bar.proto"], | |||
| deps = [ | |||
There was a problem hiding this comment.
py_proto_library from rules_python now works how all the others do
| @@ -9,7 +9,7 @@ public final class RequiredValidation { | |||
| private RequiredValidation() { | |||
| } | |||
|
|
|||
| public static void required(String field, GeneratedMessageV3 value) throws ValidationException { | |||
| "requirements.in", | ||
| "setup.cfg", | ||
| ]) | ||
|
|
||
| compile_pip_requirements( |
There was a problem hiding this comment.
this also creates a test to make sure the lockfile is updated, so the new lockfile is slightly easier to manage with that
This modernizes the bazel setup to support 7.x, still using the WORKSPACE
keith
force-pushed
the
ks/update-bazel-and-deps
branch
from
bb398ce
to
e60389d
Compare
|
@rodaine could you take a look at this one? I just rebased but looks like you need to approve the CI run |
|
thanks! pushed a fix for that failure, hopefully that's the only one! |
|
green 🎉 |
This modernizes the bazel setup to support 7.x, still using the WORKSPACE