toJson return value inferred as JsonValue when passing any options

[lourd]

I'm trying out the connect-es v2 RC with @bufbuild/protobuf 2.2.0.

When passing any available options to the toJson function, the return type is inferred as JsonValue instead of the {Message}Json type. This happens regardless of whether or not the json_types option is set to true for the protoc-gen-es.

The expected outcome here is that the return type is the {Message}Json type; the ideal outcome is that the type also takes into account the options given and infers more specific types, e.g. when enumAsInteger is given, any enums are a number in the type.

[timostamm]

You have to specify the options literal with as const, see https://github.com/bufbuild/protobuf-es/blob/v2.2.0/packages/protobuf/src/to-json.ts#L143.

But you'll only get the JSON type for the standard options, since that's what the generated JSON type matches.

I agree that it would be ideal if the returned type honored non-standard options, but unfortunately I don't see how we could support that.