Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename buf_api_token to buf_token #217

Closed
hariso opened this issue Aug 1, 2024 · 2 comments
Closed

Rename buf_api_token to buf_token #217

hariso opened this issue Aug 1, 2024 · 2 comments

Comments

@hariso
Copy link

hariso commented Aug 1, 2024

... or vice versa.:)

Firstly, thanks for this great product and also for all these GH actions!

I'd like to suggest renaming the configuration parameter buf_api_token to buf_token since that's what most (all?) other Buf actions use (lint, breaking, push).

@emcfarlane
Copy link
Contributor

Hey @hariso , we have recently v1 buf's new GitHub action buf-action. This has the input configuration token. Please take a look!

@hariso
Copy link
Author

hariso commented Aug 1, 2024

Whoops, embarrassing :D

Thanks @emcfarlane !

@nicksnyder nicksnyder closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants