Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver sort does not work #11

Open
flanec opened this issue Dec 15, 2021 · 1 comment
Open

semver sort does not work #11

flanec opened this issue Dec 15, 2021 · 1 comment

Comments

@flanec
Copy link

flanec commented Dec 15, 2021

also test/spec/version.spec.js:6 version number strings: › #6 test case is not executed with npm test, since the version.js file is ignored by jest.

to reproduce the the issue:

  • rename file, mv ./test/spec/version.spec.ts ./test/spec/1test.spec.ts
  • run tests, npm test

it will fail with error:

  ● version number strings:  › #6

    expect(received).toEqual(expected)

    Expected value to equal:
      ["1.9.0", "1.10.0", "1.11.0"]
    Received:
      ["1.10.0", "1.11.0", "1.9.0"]

    Difference:

    - Expected
    + Received

      Array [
    -   "1.9.0",
        "1.10.0",
        "1.11.0",
    +   "1.9.0",
      ]
@dscalzi
Copy link

dscalzi commented Mar 17, 2023

I added a fix that seems to work in https://github.com/dscalzi/natsort-esm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants