Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingus.core.chords.augmented_minor_seventh() nomenclature #89

Open
BonifacioCalindoro opened this issue Dec 27, 2021 · 1 comment
Open

Comments

@BonifacioCalindoro
Copy link

Reading the docs, i see this function creates a 7+5 chord, and i think it should be creating a m7+5 based on chord nomenclature. My main point is that C minor seventh means C minor with a minor seventh, C major seventh means C major with a major seventh, and C7 means C major with a minor seventh. The conclusion here is that "minor" affects the root, and "major" affects the seventh, so the "minor" in augmented_minor_seventh() should minorize the 3rd, not the 7th. Basically, the chord resulting from augmented_minor_seventh() function returns an augmented seventh chord, or C+7, while IMO should be returning Cm7+5 or something like that.

And one last thing, in the docs also states that the hendrix() chord is a 7b12, which actually is a 7#9 (the formula does the right calculations, but the docs define it wrong)

@BonifacioCalindoro
Copy link
Author

Maybe i rushed too much writing this comment, didn't even think that augmentating a minor chord wouldn't make sense cause it would turn the initial chord to a 1st inversion b6 major chord. My apologies. But the hendrix issue still going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant