Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Allow redislock to compatible with multi versions of go-redis #77

Open
git-hulk opened this issue Mar 21, 2024 · 3 comments
Open

Comments

@git-hulk
Copy link
Contributor

Currently, redislock only depends on the Redis EVAL/EVALSHA command
but directly introduces the go-redis/v9 scripter as the RedisClient interface.
And make it incompatible with other versions of the Redis client like go-redis/v8.

I think we can avoid binding to any versions by moving the scripter outside the go-redis.

I will be happy to support this if it sounds good to you.

related issue: #48

@dim
Copy link
Member

dim commented Mar 21, 2024

Sounds good in principle, but I am not sure how this would work in practice. Do you mind a PR?

@git-hulk
Copy link
Contributor Author

@dim Sure, thank you! I will submit a PR for this.

@harryeti
Copy link

@git-hulk I have the same requirement and need to connect to two different versions of redis at the same time. Looking forward to your PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants