-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 0.4.6 #77
Open
mxmCherry
wants to merge
6
commits into
main
Choose a base branch
from
mxmCherry-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
version 0.4.6 #77
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4e4d3bf
version 0.4.6
mxmCherry cadab16
hk: bundle install after gemspec ver bump
mxmCherry 0938f56
workaround (ruby): downgrade dry-types for ruby 2.x
mxmCherry c3cf6ec
fix: oops, dry-types version is 1.7.1, not 2.7.1
mxmCherry 749ecd2
fix (ruby): upgrade Gemfile.lock after downgrading+fixing dry-types ver
mxmCherry 7cea615
BREAKING: drop ruby v2 support, set gemspec version to 0.5.0
mxmCherry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,41 @@ | ||
PATH | ||
remote: . | ||
specs: | ||
grape-kaminari (0.4.5) | ||
grape-kaminari (0.5.0) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I consider dropping major Ruby version support a breaking change. But this is the only breaking change -- otherwise all the accumulated changes are dep bumps. |
||
grape (>= 1.6.1) | ||
kaminari-grape | ||
|
||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
activesupport (7.0.7.2) | ||
activesupport (7.1.3.3) | ||
base64 | ||
bigdecimal | ||
concurrent-ruby (~> 1.0, >= 1.0.2) | ||
connection_pool (>= 2.2.5) | ||
drb | ||
i18n (>= 1.6, < 2) | ||
minitest (>= 5.1) | ||
mutex_m | ||
tzinfo (~> 2.0) | ||
ast (2.4.2) | ||
base64 (0.1.1) | ||
bigdecimal (3.1.8) | ||
builder (3.2.4) | ||
concurrent-ruby (1.2.2) | ||
concurrent-ruby (1.2.3) | ||
connection_pool (2.4.1) | ||
diff-lcs (1.5.0) | ||
dry-core (1.0.0) | ||
drb (2.2.1) | ||
dry-core (1.0.1) | ||
concurrent-ruby (~> 1.0) | ||
zeitwerk (~> 2.6) | ||
dry-inflector (1.0.0) | ||
dry-logic (1.5.0) | ||
concurrent-ruby (~> 1.0) | ||
dry-core (~> 1.0, < 2) | ||
zeitwerk (~> 2.6) | ||
dry-types (1.7.1) | ||
dry-types (1.7.2) | ||
bigdecimal (~> 3.0) | ||
concurrent-ruby (~> 1.0) | ||
dry-core (~> 1.0) | ||
dry-inflector (~> 1.0) | ||
|
@@ -39,19 +48,20 @@ GEM | |
mustermann-grape (~> 1.0.0) | ||
rack (>= 1.3.0) | ||
rack-accept | ||
i18n (1.14.1) | ||
i18n (1.14.5) | ||
concurrent-ruby (~> 1.0) | ||
json (2.6.3) | ||
kaminari-core (1.2.2) | ||
kaminari-grape (1.0.1) | ||
grape | ||
kaminari-core (~> 1.0) | ||
language_server-protocol (3.17.0.3) | ||
minitest (5.19.0) | ||
minitest (5.23.1) | ||
mustermann (3.0.0) | ||
ruby2_keywords (~> 0.0.1) | ||
mustermann-grape (1.0.2) | ||
mustermann (>= 1.0.0) | ||
mutex_m (0.2.0) | ||
parallel (1.23.0) | ||
parser (3.2.2.3) | ||
ast (~> 2.4.1) | ||
|
@@ -118,7 +128,7 @@ GEM | |
tzinfo (2.0.6) | ||
concurrent-ruby (~> 1.0) | ||
unicode-display_width (2.4.2) | ||
zeitwerk (2.6.11) | ||
zeitwerk (2.6.14) | ||
|
||
PLATFORMS | ||
ruby | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
module Grape | ||
module Kaminari | ||
VERSION = '0.4.5'.freeze | ||
VERSION = '0.5.0'.freeze | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dim I'm dropping ruby v2. Too much hassle with the deps (mostly dry-XXX indirect deps), there are few dry-XXX packages and their latest versions are requiring ruby v3, I don't want to list and override (downgrade) versions for all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, I don't know why we enumerate all the minor Ruby versions there + how many last versions should we aim to support, so enumerated all the 3.x available as of today.