-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
act as textconv so can git diff inventory #295
Comments
2nd paragraph from perform diffs on binary files Didn't see The program should take a single argument. Which would necessitate an additional entrypoint to act as a textconv program
Which can only be used with inventory files and produces plain text onto stdout |
I like this! And yeah, it should be a matter of writing a new I probably won't be able to get to this right away -- if you're interested, feel free to put a PR together for it. |
Thank you for your enthusiastic approval for this feature. That, and your advice, are very much appreciated and what i was seeking. This is on me. I got this. ETA 2-3 days |
- feat: entrypoint sphobjinv-textconv ([bskinn#295]) - test: add sphobjinv-textconv unittests offline and online - test: add integration test. Demonstrate git diff objects.inv - test: add pytest module with class to interact with git - docs: add step by step guide to configure git. Both bash and python code examples - docs: added sphobjinv-textconv API docs
Switching this from |
Is your feature request related to a problem? Please describe.
git can be informed on which files are binary. And then instructed how to convert the binary files into text files, so
git diff
can work.git passes in the .inv file name cuz the
git diff
is occurring on the .inv, not on the .txt file.sphobjinv convert plain
requires a hyphen to be passed in to have the output sent to stdout. Instead would like a option flag. So then sphobjinv can act as a textconvdocs/.gitattributes
Describe the solution you'd like
Provide a --stdout option flag as another means to specify the outfile hyphen.
Describe alternatives you've considered
Alternative approach, which i'm using now, is to mark the inventory files as binary and not be able to use
git diff
docs/.gitattributes
Additional context
#159 is a similar feature request, but for stdin
The difference is infile is a required positional argument whereas outfile is optional. So a --stdout flag would not change sphobjinv command line interface
perform diffs on binary files
the fallback, indicate files are binary
The text was updated successfully, but these errors were encountered: