Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FuseSoC core files #14

Open
flaviens opened this issue Oct 9, 2022 · 2 comments
Open

Add FuseSoC core files #14

flaviens opened this issue Oct 9, 2022 · 2 comments

Comments

@flaviens
Copy link

flaviens commented Oct 9, 2022

Hi there!

I created some FuseSoC cores for this project in a new repo. The goal is to improve dependency management (for the moment it relies on git submodules).
Do you want to integrate them into this repo or should we keep them separate?
If you want to integrate them to this repo, for the future it may be favorable to move from Makefiles to FuseSoC for the testing process as well.

Thanks!
Flavien

@dpetrisko
Copy link
Collaborator

Hi, awesome!

I think based on this example that it's preferred to have separate core file repos.

https://github.com/fusesoc/fusesoc-cores

From a maintenance perspective, it seems like having the core files versioned with the code would be better, so we could change them atomically. Maybe the best is to have a subdirectory in the repo that provides the core files? And then when adding the library we use the raw path to the core directory instead of the toplevel git url?

Seems like a discussion we should have with Olof

@flaviens
Copy link
Author

Created PR #15.

Maybe the best is to have a subdirectory in the repo that provides the core files

I agree that would look the most elegant.
However, FuseSoC does not seem to like this. If I locate the core files in a new fusesoc directory, then it says:

WARNING: The file ../source/<blablabla>.v in <path to hardfloat>/fusesoc/hardfloat_RISCV.core is not within the directory containing the core file. This is deprecated and will be an error in a future FuseSoC version. A typical solution is to move core file into the root directory of the IP block it describes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants