-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bindings of skinview3d #107
Comments
@g-plane I wouldn't mind if we move react-skinview3d to this org and give it a more concise and extensible API. Don't really have much experience with creating ng/Vue libraries though. |
It can be a breaking change if API of |
I'd say confusion is possible but that's what major versions are for 😅. |
I may put all binding packages into a monorepo. Do we have a nice way to migrate that? |
Not really but you can take the source of mine. What monorepo tool do you plan on using? |
Just pnpm, nothing else. |
Would it be a good idea to maybe scope these packages like Not sure there is an npm org set up for this but something we could here input on from @yushijinhun. |
I'd like that the npm organization name can be "skinview3d", and they will be "@skinview3d/react" and "@skinview3d/vue", etc. |
Hi 👋 I have decided to make a vue binding of skinview3d. Please let me know if you want to put it in a monorepo :) |
Welcome. |
Here it is: https://github.com/so1ve/vue-skinview3d |
Been keeping react-skinview3d updated as well. Initially the wrapper was very opinionated and lacking support for much customization but now you should be able to do almost anything skinview3d can. I've created the npm organization @g-plane I'd prefer to use turborepo for the monorepo, do you have objections? Current standing of bindings so far some of which may never happen. |
I prefer Turborepo too. |
I can create a binding for solid too, but I'd like to work on it after we merge the existing bindings into a monorepo to reduce workload. |
@g-plane do you want to still continue this or should we close out this issue? |
I don't have time on working on this, but I think we can keep this open for those interested in it. |
@g-plane can you create a new repo and we can move this issue to it? |
I think we can turn this repo into monorepo by using pnpm. |
@g-plane but I think it's better to keep the source separated from lib bindings. |
@yushijinhun How do you think? |
In principle, nothing prevents you from leaving the main skinview3d library here and creating a separate mono repository for bindings. By the way, I can also help with this. |
I'm going to create some packages which are bindings of skinview3d for some popular front-end frameworks/libraries. These packages will provide components and accept properties then pass them to skinview3d.
Currently these frameworks are considered:
The frameworks below will not be supported:
Additionally, I'm going to create a special binding which will provide Web Components. This allows users to use it if they don't use any front-end frameworks or they're using unsupported frameworks we mentioned above. (Angular and Vue.js 2 support Web Components.)
I've noticed that @Hacksore has created a package for React: Hacksore/react-skinview3d, but it doesn't provide "many options" to let users control the behavior of skinview3d. Personally, I think it could be reasonable since it keeps simple for those users who don't care too much. But for some advanced users, such as Blessing Skin, it's not enough, so I'm not sure if we need to create another binding (It doesn't mean it will replace @Hacksore 's package.), and I'd like to hear from @Hacksore .
The text was updated successfully, but these errors were encountered: