Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wiki entry for how the application handles IBC MsgTransfer, MsgAck and MsgRecvPacket as sends/receives #505

Open
pharr117 opened this issue Oct 26, 2023 · 1 comment
Open

Add Wiki entry for how the application handles IBC MsgTransfer, MsgAck and MsgRecvPacket as sends/receives #505

pharr117 opened this issue Oct 26, 2023 · 1 comment
Assignees
@pharr117
Labels
research

Comments

@pharr117
Copy link
Collaborator

pharr117 commented Oct 26, 2023 •
edited
Loading

We have been message type ignoring MsgTransfer. This is due to the following commit:

279283f

The original idea was to only index MsgAcks, so that we would not have a double send value:

  1. MsgTransfer -> ignored
  2. MsgAck -> indexed as a send

Some users have questioned why MsgTransfer transactions are not being indexed and we should dig into this behavior a bit more and see if the logic is correct.
@pharr117 pharr117 added the bug Something isn't working label Oct 26, 2023
@pharr117 pharr117 self-assigned this Oct 26, 2023
@pharr117 pharr117 changed the title MsgTransfer is ignored in preference of MsgAck to track outbound transfers leading to CSV generation confusion Add Wiki entry for how the application handles IBC MsgTransfer, MsgAck and MsgRecvPacket as sends/receives Oct 29, 2023
@pharr117 pharr117 moved this to Todo in Defiant OSS Oct 29, 2023
@pharr117
Copy link
Collaborator Author

We will be adding a wiki entry to explain how the application indexes IBC messages as sends/receives

@pharr117 pharr117 added research and removed bug Something isn't working labels Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pharr117 pharr117

Labels
research
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pharr117