Highcharts local directory is hardcoded in install-all.sh script

[brunobuzzi]

From Jupiter:
I’ve just done a fresh install of BpmFlow into GS 3.5.1 using the load-all.sh script.

I noticed that the Javascript files from the Highcharts and Highstock file libraries are not loading:

/files/highcharts-6.0.3/js/highcharts-more.js not found
/files/highstock-6.0.3/js/highstock.src.js not found
/files/highstock-6.0.3/modules/exporting.src.js not found
/files/highstock-6.0.3/modules/heatmap.src.js not found

However, .css files from the same file libraries are loading correctly.

Have you seen this? I’ve tried the process a few times now and see the same result.

[brunobuzzi]

Check line 89 to 96:

GsDeployer deploy: [
    Metacello new
         baseline: 'HighchartsSt';
         filetreeDirectory: '/home/gemstone/GsDevKit_home/shared/repos/HighchartsSt/repository';
         onLock: [:ex | ex honor];
		     onConflictUseLoaded;
         load.
].

The local Highchart directory is hardcoded to my Linux user (gemstone):
filetreeDirectory: '/home/gemstone/GsDevKit_home/shared/repos/HighchartsSt/repository';

[JupiterJones]

I updated the path in install-all.sh before installing. Highcharts has installed correctly and the file library is present in the image. It's only the javascript files that are not loading. The css files from the libraries are loading correctly.

I've had a quick look and was wondering if it's related to the WADeploymentAwareFileHandler - which is not installed as the 'files' handler.

I'll get a chance over the weekend to look further.

[brunobuzzi]

• 1) The linux user name in install-all.sh script should be dynamic and not hardcoded

[JupiterJones]

Perhaps it should simply use $GS_HOME and have a check to ensure $GS_HOME is set.

[brunobuzzi]

WADeploymentAwareFileHandler is from Boardwalk package and it is a dependency of Highcharts but i do not think that is the problem.

WADeploymentAwareFileHandler is not used in my GS images.

• Does other JS files are copied correctly ?
• Does Highstock6DevelopmentMetadataLibrary class has the JS method missing in /files/.... ?
  For example:
  Highstock6DevelopmentMetadataLibrary>>highstocksrcJs
  Highstock6DevelopmentMetadataLibrary>>highchartsmoresrcJs

[brunobuzzi]

I did a fresh installation and all those files are present.

[JupiterJones]

Yes, all the javascript files are present in the library, just not being served - not found errors.
Everything else from the library is being served, just not the JS files.

I'll get a chance to look again tomorrow

[brunobuzzi]

Did you executed "sh register-application.sh devKit_351" ? See https://bpmflow.gitbook.io/project/installation/bpm-flow

[brunobuzzi]

This has been fixed. It needs a couple of more installation test then can be closed !

[brunobuzzi]

@JupiterJones it seems that this is fixed with:
https://github.com/brunobuzzi/BpmFlow/blob/master/scripts/install-all.sh#L126
More exactly:
https://github.com/brunobuzzi/BpmFlow/blob/master/scripts/install-all.sh#L125-L143